Ticket #146 (closed enhancement: fixed)

Opened 6 months ago

Last modified 6 months ago

Make MailSender non IO-blocking

Reported by: pablo Owned by: pablo
Priority: major Milestone: 0.9
Component: code Version: 0.8
Keywords: Cc: daniel pablo

Description (last modified by pablo) (diff)

Currently, scrapy.mail.MailSender is IO-blocking due to a bug in the (non IO-blocking) dispatching mechanism.

To quote the FIXME comment in scrapy/mail.py:

        # FIXME ----------------------------------------------------------
        # There seems to be a problem with sending emails using deferreds when
        # the last thing left to do is sending the mail, cause the engine stops
        # the reactor and the email don't get send. we need to fix this. until
        # then, we'll revert to use Python standard (IO-blocking) smtplib.

We need to fix this and make MailSender non IO-blocking and correct.

Change History

Changed 6 months ago by pablo

  • description modified (diff)

Changed 6 months ago by pablo

  • status changed from new to closed
  • resolution set to fixed

Done in r1955

Note: See TracTickets for help on using tickets.